[Fix] return valid values on multi-byte-wide TypedArray input #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChALkeR
force-pushed
the
chalker/fixes/3.0.x/1
branch
7 times, most recently
from
50d3575
to
8640bef
Compare
ChALkeR
force-pushed
the
chalker/fixes/3.0.x/1
branch
from
8640bef
to
48a70d2
Compare
ljharb
reviewed
Nov 21, 2024
| * Makes sense only on engines with full TypedArray support -- let Buffer detect that | ||
| */ | ||
| if (useArrayBuffer && ArrayBuffer.isView(data)) { | ||
| if (data.byteLength === 0) return Buffer.alloc(0) // Bug in Node.js <6.3.1, which treats this as out-of-bounds |
There was a problem hiding this comment.
does this mean it breaks in these versions?
There was a problem hiding this comment.
This line is a fix for those versions
They are only problematic on zero-length arraybuffers, so a check helps
| t.test('handle UInt16Array', function (t) { | ||
| beforeEach(t, createHashBase) | ||
|
|
||
| if (ArrayBuffer.isView && (Buffer.prototype instanceof Uint8Array || Buffer.TYPED_ARRAY_SUPPORT)) { |
There was a problem hiding this comment.
these checks can go in a { skip: } options arg to the test. Often i do { skip: condition && 'explanation' } and it displays nicely.
Co-authored-by: Jordan Harband <[email protected]>
Co-authored-by: Jordan Harband <[email protected]>
Co-authored-by: Jordan Harband <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of browserify/cipher-base#23 to
hash-basewith minor code cleanupThis technically would have been a Feat, but Node.js handles it, and this module declares support for the same API as Node.js crypto in the readme
So, a Fix
.updateinput is converted to Buffer for all supported types and is passed to._updateas a buffer, so this doesn't require any changes in the libraries usinghash-baseto just workChanges an error message but it's also like that in Node.js