feat(storage)!: reduce remove_blocks IO
#472
Draft
+122
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rexagon
force-pushed
the
feature/reduce-remove-blocks-io
branch
2 times, most recently
from
2e8322a
to
7936c43
Compare
BREAKING: A new column family is required now - `full_block_ids`
Rexagon
force-pushed
the
feature/reduce-remove-blocks-io
branch
from
7936c43
to
8ff4180
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #472 +/- ##
==========================================
- Coverage 43.00% 42.99% -0.02%
==========================================
Files 266 266
Lines 46484 46517 +33
Branches 46484 46517 +33
==========================================
+ Hits 19989 19998 +9
- Misses 25413 25440 +27
+ Partials 1082 1079 -3 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
0xdeafbeef
approved these changes
Nov 24, 2024
| } | ||
| } | ||
|
|
||
| impl ColumnFamilyOptions<Caches> for FullBlockIds {} |
There was a problem hiding this comment.
set caches via default_block_based_table_factory
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING: A new column family is required now -
full_block_ids