fix(collator): remove all collated block ids from mismatched one #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/imp-sync-long-tail #600 +/- ##
==========================================================
Coverage ? 42.69%
==========================================================
Files ? 278
Lines ? 52161
Branches ? 52161
==========================================================
Hits ? 22268
Misses ? 28727
Partials ? 1166 ☔ View full report in Codecov by Sentry. |
SmaGMan
force-pushed
the
fix/clean-uncommitted-diffs-on-mismatch
branch
from
0bbc868 to
bbe9911
Compare
… sync and queue restore Last processed master block may be incorrect when collator made some incorrect blocks before we received correct one from bc. In this case, we may skip required queue diffs on sync. So we should consider only last collated and previous synced_to master blocks to define queue restore range.
SmaGMan
force-pushed
the
fix/clean-uncommitted-diffs-on-mismatch
branch
from
c9ecf02 to
7c0b2c1
Compare
…n collected in all partitions * otherwise it causes an incorrect messages buffers refill after sync when there are messages in other partitions except partition 0, and collator produces an incorrect block
* to guarantee an identical logic for collation on continue and after sync
SmaGMan
force-pushed
the
fix/clean-uncommitted-diffs-on-mismatch
branch
from
e8b4e65 to
fa3fff4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.