fix empty materialization and add test

bruin-data · Mar 13, 2024 · 34b0eba · 34b0eba
1 parent 7973856
commit 34b0eba
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/pkg/pipeline/materializer.go b/pkg/pipeline/materializer.go
@@ -17,7 +17,7 @@ type Materializer struct {
 func (m *Materializer) Render(asset *Asset, query string) (string, error) {
 	mat := asset.Materialization
 	if mat.Type == MaterializationTypeNone {
-		return query, nil
+		return removeComments(query), nil
 	}
 
 	if matFunc, ok := m.MaterializationMap[mat.Type][mat.Strategy]; ok {
@@ -35,6 +35,6 @@ func (m *Materializer) Render(asset *Asset, query string) (string, error) {
 func removeComments(query string) string {
 	bytes := []byte(query)
 	re := regexp.MustCompile("(?s)/\\*.*?\\*/")
-	newBytes := re.ReplaceAll(bytes, nil)
+	newBytes := re.ReplaceAll(bytes, []byte(""))
 	return string(newBytes)
 }
diff --git a/pkg/pipeline/materializer_test.go b/pkg/pipeline/materializer_test.go
@@ -20,7 +20,7 @@ func TestMaterializer_Render(t *testing.T) {
 		},
 	}
 
-	query := "SELECT * FROM table"
+	query := "/* @bruin some yaml @bruin*/SELECT * FROM table"
 	expected := "SELECT * FROM table"
 
 	result, err := materializer.Render(asset, query)