ClickHouse: Add Support for Secure Connection #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanjushahgupta
changed the title
turtleDev
requested changes
Feb 3, 2025
pkg/clickhouse/config.go
Outdated
| @@ -28,10 +29,18 @@ func (c *Config) ToClickHouseOptions() *click_house.Options { | |||
| } | |||
|
|
|||
| func (c *Config) GetIngestrURI() string { | |||
| //nolint:nosprintfhostport | |||
| uri := fmt.Sprintf("clickhouse://%s:%s@%s:%d", c.Username, c.Password, c.Host, c.Port) | |||
There was a problem hiding this comment.
I would recommend using url package to build the URI. It will automatically escape URI characters, making this a lot more robust.
There was a problem hiding this comment.
turtleDev
reviewed
Feb 3, 2025
| @@ -13,6 +13,7 @@ type Config struct { | |||
| Port int | |||
| Database string | |||
| HTTPPort int | |||
| Secure *int | |||
There was a problem hiding this comment.
Can we avoid using pointers?
Instead treat 0 as the null value.
There was a problem hiding this comment.
No, we cannot treat 0 as a null value because 0 indicates a non-secure connection, 1 means a secure connection, and "not set" is represented as nil. For that I have to use pointer
turtleDev
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following changes are made in this PR: