Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prism to v1.21.0 #158

Merged
merged 1 commit into from
Oct 1, 2020
Merged

Update prism to v1.21.0 #158

merged 1 commit into from
Oct 1, 2020

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR
Copy link
Contributor Author

BTW @bryanbraun have you thought about deploying to the gh-pages branch only on tags or manually? Right now, there's a chance that docs are broken if one does not run npm run build. We can automate this with GitHub Actions easily.

@@ -944,6 +944,6 @@ <h3>Tooltip</h3>
var hovEx5 = new AnchorJS({ icon: 'Permalink' });
hovEx5.add('.hover-examples .example:nth-child(5) h3');
</script>
<script src="https://cdn.jsdelivr.net/prism/1.5.1/prism.js" async></script>
<script src="https://cdn.jsdelivr.net/npm/[email protected]/prism.min.js" async></script>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooo, getting the minified version is a nice improvement. 😄

@bryanbraun bryanbraun merged commit 13e098f into bryanbraun:master Oct 1, 2020
@bryanbraun
Copy link
Owner

BTW @bryanbraun have you thought about deploying to the gh-pages branch only on tags or manually? Right now, there's a chance that docs are broken if one does not run npm run build. We can automate this with GitHub Actions easily.

Yeah the "Copy to docs" setup is a little awkward. I'm inclined to not refine this too much right now, because I suspect that some of it will change after I work on #109 .

One option is to deploy the whole repo to github-pages instead of just the /docs folder. That would allow me to link the JS file directly, so the docs would reference the anchor.js on master. I did something like that for https://github.com/bryanbraun/checkboxland.

Github Actions is pretty nice too, though, so lots of options. 😄

@XhmikosR XhmikosR deleted the update-prism branch October 7, 2020 04:30
@XhmikosR
Copy link
Contributor Author

XhmikosR commented Oct 7, 2020

I think the best approach would be to deploy with GitHub Actions. That way, you can make sure the live site is indeed the latest master code, assuming you want that and not the latest tag (we can go either way). For example, we deploy our blog from the main branch on https://github.com/twbs/blog/blob/main/.github/workflows/ci.yml

Anyway, let me know if you'd like me to submit a PR for this. You will just need to change the deployment options :)

@bryanbraun
Copy link
Owner

@XhmikosR, thanks for the example with twbs. I'll keep thinking about the deploy thing. I'll create an issue and ping you if I feel like it's time to go in that direction. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants