Implementation of SA-1 BW-RAM protection #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manually cherry-picked ares commit ares-emulator/ares@70f3610. Co-Authored-By: absindx <[email protected]>
|
Was this tested against real hardware or only with the SD2SNES? Could it be a concern that this is emulating the SD2SNES implementations of SA-1 rather than the original hardware? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manually cherry-picked ares commit ares-emulator/ares@70f3610.
Testing with the test rom from https://github.com/absindx/SNES-TestRoms/tree/267b128a84afdd250a51967963fa7fba4184399e/SA1RamProtectionTest, the following previously failing tests now pass:
2, 6, 39-66, 93-118, 155, 157-166, 168, 172, 179-190, 192, 194, 195, 198, 199, 203, 204, 208, 209, 211, 213, 215, 216* (test 216 freezes and doesn't allow progressing to further tests).