Using explicit frontend url.

bsommardahl · Oct 30, 2024 · a744ef9 · a744ef9
1 parent 06ee462
commit a744ef9
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/.github/workflows/cd-frontend.yml b/.github/workflows/cd-frontend.yml
@@ -16,6 +16,9 @@ on:
       frontend_host:
         required: true
         type: string
+      frontend_url:
+        required: true
+        type: string
       bucket_name:
         required: true
         type: string
@@ -28,7 +31,7 @@ on:
         required: true
     outputs:
       frontend_url: 
-        value: http://${{inputs.frontend_host}}
+        value: ${{inputs.frontend_url}}
       s3_bucket_hostname: 
         value: ${{inputs.frontend_host}}
 
@@ -38,7 +41,7 @@ jobs:
     runs-on: ubuntu-latest
     environment:
       name: S3 Bucket Frontend
-      url: http://${{inputs.frontend_host}}
+      url: ${{inputs.frontend_url}}
     steps:
       - name: Get Frontend Artifact
         uses: actions/download-artifact@v4
@@ -80,7 +83,7 @@ jobs:
 
       - name: Run Frontend Smoke Test
         run: |
-          export TEST_URL=${{inputs.frontend_host}}
+          export TEST_URL=${{inputs.frontend_url}}
           cd frontend/e2e
           npm install
           npm run smoke
diff --git a/.github/workflows/ci-cd.yaml b/.github/workflows/ci-cd.yaml
@@ -32,6 +32,7 @@ jobs:
       ref: ${{ github.sha }}  
       bucket_name: anyhasher-big-bang
       frontend_host: anyhasher-big-bang.s3-website-us-east-1.amazonaws.com
+      frontend_url: http://anyhasher-big-bang.s3-website-us-east-1.amazonaws.com
       backend_host: ec2-98-81-131-31.compute-1.amazonaws.com
       backend_url: http://ec2-98-81-131-31.compute-1.amazonaws.com:5000
     secrets: inherit