-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: send transfer #2
Conversation
4901ab6
to
6d018a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing to |
6d018a2
to
9a54c36
Compare
9a54c36
to
c48faa9
Compare
c48faa9
to
ec24da2
Compare
@kyranjamie ran into this locally until I added a Just a heads up for testing local dev changes. EDIT: This didn't seem to totally work either. 🤔 ...just experimenting so not important. I ended up just using the console to trigger it rather than finishing the button in the test-app right now. |
Looks good, but yeah I think a recipients array would probably be best and work for both cases |
@kyranjamie I think we decided starting singular in our tech mtg was best, did I not understand that correctly? Should I change here? |
We can start off singular as well, with the potential problem of maybe a wallet needing to support a changed standard once there is something more official / agreed upon. 🤷🏼♂️ |
Yeah, prob best just to do the array if we know that is ultimately what we want... @kyranjamie, anything I am missing/not remembering correctly about why we can't/shouldn't? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR begins to add support for signing a transaction to transfer btc.
Questions:
BtcRecipient
so an app could send an array of recipient, is that also preferred here? Ref PR: feat: add open btc transfer hirosystems/connect#285