Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: send transfer #2

Merged
merged 1 commit into from
Apr 21, 2023
Merged

Conversation

fbwoolf
Copy link
Contributor

@fbwoolf fbwoolf commented Apr 17, 2023

This PR begins to add support for signing a transaction to transfer btc.

Questions:

  1. Should the name be more specific to token transfer?
  2. The proposed PR in Connect use a BtcRecipient so an app could send an array of recipient, is that also preferred here? Ref PR: feat: add open btc transfer hirosystems/connect#285

Copy link
Contributor

@kyranjamie kyranjamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @fbwoolf.

I wonder if we should call this something more generic, like send btc, as it includes the broadcast as well? cc/ @janniks

@fbwoolf
Copy link
Contributor Author

fbwoolf commented Apr 18, 2023

Changing to sendTransfer from spreadsheet ...w/ params as an array of recipient objects. starting singular as discussed.

@fbwoolf fbwoolf force-pushed the feat/sign-transaction branch from 6d018a2 to 9a54c36 Compare April 18, 2023 17:18
@fbwoolf fbwoolf changed the title feat: sign transaction feat: send transfer Apr 18, 2023
@fbwoolf fbwoolf force-pushed the feat/sign-transaction branch from 9a54c36 to c48faa9 Compare April 18, 2023 18:17
@fbwoolf fbwoolf force-pushed the feat/sign-transaction branch from c48faa9 to ec24da2 Compare April 18, 2023 18:21
@fbwoolf
Copy link
Contributor Author

fbwoolf commented Apr 18, 2023

@kyranjamie ran into this locally until I added a name and version to the package.json: wclr/yalc#101

Just a heads up for testing local dev changes.

EDIT: This didn't seem to totally work either. 🤔 ...just experimenting so not important. I ended up just using the console to trigger it rather than finishing the button in the test-app right now.

@janniks
Copy link
Contributor

janniks commented Apr 20, 2023

Looks good, but yeah I think a recipients array would probably be best and work for both cases

@fbwoolf
Copy link
Contributor Author

fbwoolf commented Apr 20, 2023

@kyranjamie I think we decided starting singular in our tech mtg was best, did I not understand that correctly? Should I change here?

@janniks
Copy link
Contributor

janniks commented Apr 20, 2023

We can start off singular as well, with the potential problem of maybe a wallet needing to support a changed standard once there is something more official / agreed upon. 🤷🏼‍♂️

@fbwoolf
Copy link
Contributor Author

fbwoolf commented Apr 20, 2023

We can start off singular as well, with the potential problem of maybe a wallet needing to support a changed standard once there is something more official / agreed upon. 🤷🏼‍♂️

Yeah, prob best just to do the array if we know that is ultimately what we want... @kyranjamie, anything I am missing/not remembering correctly about why we can't/shouldn't?

Copy link
Contributor

@kyranjamie kyranjamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyranjamie kyranjamie marked this pull request as ready for review April 21, 2023 15:46
@kyranjamie kyranjamie merged commit 21958df into btckit-org:main Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants