chain: optimize mempool memory usage for RPC clients #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we can use `gettxspendingprevout` to check the mempool spend of an input, there's no need to maintain the large `inputs` map anymore.
This commit creates a new method `getTxSpendingPrevOut` that's used by both ZMQ and RPC clients to lookup mempool spend for a given input.
yyforyongyu
force-pushed
the
optimize-mempool
branch
from
dfe82b8 to
f2da461
Compare
Roasbeef
approved these changes
Nov 28, 2023
| @@ -236,6 +247,11 @@ func (m *mempool) containsTx(hash chainhash.Hash) bool { | |||
| // | |||
| // NOTE: must be used inside a lock. | |||
| func (m *mempool) containsInput(op wire.OutPoint) (chainhash.Hash, bool) { | |||
| // TODO(yy): port `getprevout` to bitcoind and use it here? | |||
There was a problem hiding this comment.
Doesn't this occur on a higher level rn? Or you mean pulling down that check into the mempool logic itself?
There was a problem hiding this comment.
so mempool already has an rpc client in m.cfg.client, which can be used to call the rpc method. If we use it here, then both zmq and rpc clients can use this containsInput to do the lookup without checking hasPrevRPC flag.
buck54321
pushed a commit
to buck54321/btcwallet
that referenced
this pull request
Apr 21, 2024
chain: optimize mempool memory usage for RPC clients
buck54321
pushed a commit
to buck54321/btcwallet
that referenced
this pull request
Apr 21, 2024
chain: optimize mempool memory usage for RPC clients
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the RPC client to use
gettxspendingprevoutto look up mempool spend for a given output, such that the internalinputscan be removed, which can save us quite some memory usage.