Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mod: bump Golang min version to v1.18 in all submodules #901

Merged
merged 5 commits into from
Jan 24, 2024

Conversation

guggero
Copy link
Collaborator

@guggero guggero commented Jan 15, 2024

Because the Go module behavior was changed in newer versions of Golang, running go mod tidy does produce a diff with those versions.
We'll want to have the tighter dependency logic and for that reason update all submodules to require at least Go 1.18 and run go mod tidy on all the modules.

cc @yyforyongyu

After merging the PR we'll want to push the following new tags:

  • wallet/txauthor/v1.3.4
  • wallet/txrules/v1.2.1
  • wallet/txsizes/v1.2.4
  • walletdb/v1.4.1
  • wtxmgr/v1.5.1

After pushing those tags, we'll need a new PR that bumps the main go.mod to all those versions.

@guggero guggero requested a review from Roasbeef January 15, 2024 10:57
Copy link
Collaborator

@yyforyongyu yyforyongyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🙏

Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏸

@Roasbeef Roasbeef merged commit 7e3e5ed into btcsuite:master Jan 24, 2024
3 checks passed
@guggero guggero deleted the modules-upgrade branch January 24, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants