Add option to allow for dust when checking outputs #907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You mentioned you need this for |
|
If the op return output is over the standard 80 byte limit it is considered dust. |
|
Ah yes. So you'd need a non-standard implementation of a chain backend to propagate such an output in the first place... |
|
Yeah I use Libre relay |
guggero
reviewed
Dec 9, 2024
| @@ -39,14 +39,14 @@ var ( | |||
|
|
|||
| // CheckOutput performs simple consensus and policy tests on a transaction | |||
| // output. | |||
| func CheckOutput(output *wire.TxOut, relayFeePerKb btcutil.Amount) error { | |||
| func CheckOutput(output *wire.TxOut, relayFeePerKb btcutil.Amount, allowDust bool) error { | |||
There was a problem hiding this comment.
Since this is a breaking API change, should we just create a new function CheckOutputAllowDust that has the boolean flag? Then this function can call into the new one with false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems standard in most wallet libraries nowadays to give users the option to allow for dust if they know what they are doing.