chain: make sure to WaitForShutdown
#964
Conversation
yyforyongyu
force-pushed
the
fix-shutdown
branch
from
2091fa7 to
58426bc
Compare
wallet/chainntfns.go
Outdated
| if addrmgrNs == nil { | ||
| return fmt.Errorf("%w: empty waddrmgr bucket", ErrEmptyBucket) | ||
| } |
There was a problem hiding this comment.
hmmm wondering how this can be nil if it is always created on DB construction via the create function. It's also used in many other places without first doing a nil check. So if we can determine why it can be nil here, then those would also need to be updated?
There was a problem hiding this comment.
maybe the lnd itest panic reveals some info re the path taken here?
There was a problem hiding this comment.
good question - should have kept the logs back then. This was seen in postgres, that somehow there's a goroutine accessing this data during shutdown, yet I guess the data was already GCed at the moment. Now that you mention it I think we should just let it happen and then decide what was the cause there, removed.
yyforyongyu
force-pushed
the
fix-shutdown
branch
from
58426bc to
321c0f3
Compare
Simple fix - looks like we forgot to call
WaitForShutdownand, add a nil bucket check which was found panic in one oflnd's itests.