Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps in pre-commit config and fix formatting #127

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mgunyho
Copy link

@mgunyho mgunyho commented Sep 6, 2023

I was making a commit for another PR but the pre-commit hook had an error, which seems to be a problem with isort version 5.10.1 and poetry, see here: https://stackoverflow.com/questions/75281731/pre-commit-fails-to-install-isort-5-10-1-with-error-runtimeerror-the-poetry-co. This PR fixes that.

@btel
Copy link
Owner

btel commented Sep 30, 2023

could you fix linting errors? thanks!

@mgunyho
Copy link
Author

mgunyho commented Oct 1, 2023

Oh, I didn't realize that updating black introduced new linting errors, but fixed it now! Also updated the black version to match in .github/workflows/black.yml

@mgunyho mgunyho changed the title Update deps in pre-commit config Update deps in pre-commit config and fix formatting Oct 1, 2023
@mgunyho
Copy link
Author

mgunyho commented Oct 1, 2023

This PR also closes #123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants