fixes #37 upgraded to latest version of showdown #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
|
+1 |
|
+1. The latest showdown.js is |
|
+1. The latest version of showdown.js is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've upgraded to the latest version of showdown and made the minimal set of changes necessary for the tests to pass.
The showdown extensions (Twitter, YouTube, etc.) are no longer bundled with showdown, but I've included the Twitter extension only because there's a test that relies on it.
Personally, I don't think any extensions should be bundled - instead the user should decide which (if any) of them to include in their project. If you agree, then remove the Twitter extension and the test that uses it or include it only for the tests.
Assuming this PR is acceptable, It would help me out if you could release a new version with these changes ASAP.