Add a Chunked Reader #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Incorporate suggested changes.See further comments here: 32ae813
Taking a stab in the dark that this might help. References btimby#6.
Ensure mtime matches the time displayed on the Dropbox website.
Let's make this slightly faster by getting instead of popping. Also, don't get mtime twice by using if/else.
Since the get() function defaults to None, it is not needed.
Replace "errno=e.status" with "details=e". errno should be a property of details rather than a keyword argument.
Use the standard path (/usr/bin) for env. Capitalize PyFilesystem as in its documentation. PEP-8 fixes.
* header size looked too much the same. * build should be past tense
…he dropbox 1.6 client and do not have a start parameter on open_file. References btimby#2
…. Also allow multiple attempts to close remote dropbox file. References btimby#2
Add seek to the chunkedReader. Closes btimby#2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References Issue #4