refactor: change the Experiment storage scope to QueryExecer #1618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kakcy
force-pushed
the
update-storage-client-experiment-2
branch
from
419461b to
cba2402
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
experimentStorageandgoalStorageto usemysql.QueryExecerinstead ofmysql.Clientand updates the corresponding tests to reflect this change. The main changes involve replacingclientwithqein the storage structs and updating method calls accordingly.This PR is a refactor to the deprecation of
Client.Qe()in the PR below.#1549
Client.Qe()is unnecessary so it has been removed.