fix checkout permission

bufbuild · Nov 10, 2023 · 24b5a41 · 24b5a41
1 parent 0afb69c
commit 24b5a41
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/.github/workflows/create-release-pr.yaml b/.github/workflows/create-release-pr.yaml
@@ -1,9 +1,5 @@
 name: Create Release PR
 on:
-  # todo: remove push
-  push:
-    branches:
-      - osun/fix-git-permission
   workflow_dispatch:
     inputs:
       version:
@@ -32,7 +28,6 @@ jobs:
       - name: Create release PR
         run: bash ./make/buf/scripts/createreleasepr.bash
         env:
-          GITHUB_TOKEN: ${{ steps.app_token.outputs.token }}
-          # VERSION: ${{ github.event.inputs.version }}
-          VERSION: 1.28.0-test
+          GH_TOKEN: ${{ steps.app_token.outputs.token }}
+          VERSION: ${{ github.event.inputs.version }}
           WEBHOOK_URL: ${{ secrets.SLACK_RELEASE_NOTIFICATION_WEBHOOK }}
diff --git a/make/buf/scripts/createreleasepr.bash b/make/buf/scripts/createreleasepr.bash
@@ -8,7 +8,7 @@ cd "${DIR}"
 # We already have set -u, but want to fail early if a required variable is not set.
 : ${WEBHOOK_URL}
 # However, if you are already logged in for GitHub CLI locally, you can remove this line when running it locally.
-# : ${GH_TOKEN}
+: ${GH_TOKEN}
 
 if [[ "${VERSION}" == v* ]]; then
   echo "error: VERSION ${VERSION} must not start with 'v'" >&2