Skip to content

Commit

Permalink
Fix naming
Browse files Browse the repository at this point in the history
  • Loading branch information
emcfarlane committed Oct 28, 2024
1 parent 73cfa3b commit 64eda56
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 14 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -120,9 +120,9 @@ func run(
if err != nil {
return err
}
clientProvider := bufregistryapimodule.NewClientProvider(clientConfig)
moduleClientProvider := bufregistryapimodule.NewClientProvider(clientConfig)
moduleFullName := moduleRef.ModuleFullName()
labelServiceClient := clientProvider.V1LabelServiceClient(moduleFullName.Registry())
labelServiceClient := moduleClientProvider.V1LabelServiceClient(moduleFullName.Registry())
order := modulev1.ListLabelsRequest_ORDER_UPDATE_TIME_DESC
if flags.Reverse {
order = modulev1.ListLabelsRequest_ORDER_UPDATE_TIME_ASC
Expand Down
24 changes: 12 additions & 12 deletions private/bufpkg/bufmodule/bufmoduleapi/universal_proto_commit.go
Original file line number Diff line number Diff line change
Expand Up @@ -70,15 +70,15 @@ func newUniversalProtoCommitForV1Beta1(v1beta1ProtoCommit *modulev1beta1.Commit)

func getUniversalProtoCommitForRegistryAndCommitID(
ctx context.Context,
clientProvider interface {
moduleClientProvider interface {
bufregistryapimodule.V1CommitServiceClientProvider
bufregistryapimodule.V1Beta1CommitServiceClientProvider
},
registry string,
commitID uuid.UUID,
digestType bufmodule.DigestType,
) (*universalProtoCommit, error) {
universalProtoCommits, err := getUniversalProtoCommitsForRegistryAndCommitIDs(ctx, clientProvider, registry, []uuid.UUID{commitID}, digestType)
universalProtoCommits, err := getUniversalProtoCommitsForRegistryAndCommitIDs(ctx, moduleClientProvider, registry, []uuid.UUID{commitID}, digestType)
if err != nil {
return nil, err
}
Expand All @@ -88,7 +88,7 @@ func getUniversalProtoCommitForRegistryAndCommitID(

func getUniversalProtoCommitsForRegistryAndCommitIDs(
ctx context.Context,
clientProvider interface {
moduleClientProvider interface {
bufregistryapimodule.V1CommitServiceClientProvider
bufregistryapimodule.V1Beta1CommitServiceClientProvider
},
Expand All @@ -99,14 +99,14 @@ func getUniversalProtoCommitsForRegistryAndCommitIDs(
switch digestType {
case bufmodule.DigestTypeB4:
v1beta1ProtoResourceRefs := commitIDsToV1Beta1ProtoResourceRefs(commitIDs)
v1beta1ProtoCommits, err := getV1Beta1ProtoCommitsForRegistryAndResourceRefs(ctx, clientProvider, registry, v1beta1ProtoResourceRefs, digestType)
v1beta1ProtoCommits, err := getV1Beta1ProtoCommitsForRegistryAndResourceRefs(ctx, moduleClientProvider, registry, v1beta1ProtoResourceRefs, digestType)
if err != nil {
return nil, err
}
return slicesext.MapError(v1beta1ProtoCommits, newUniversalProtoCommitForV1Beta1)
case bufmodule.DigestTypeB5:
v1ProtoResourceRefs := commitIDsToV1ProtoResourceRefs(commitIDs)
v1ProtoCommits, err := getV1ProtoCommitsForRegistryAndResourceRefs(ctx, clientProvider, registry, v1ProtoResourceRefs)
v1ProtoCommits, err := getV1ProtoCommitsForRegistryAndResourceRefs(ctx, moduleClientProvider, registry, v1ProtoResourceRefs)
if err != nil {
return nil, err
}
Expand All @@ -118,7 +118,7 @@ func getUniversalProtoCommitsForRegistryAndCommitIDs(

func getUniversalProtoCommitsForRegistryAndModuleRefs(
ctx context.Context,
clientProvider interface {
moduleClientProvider interface {
bufregistryapimodule.V1CommitServiceClientProvider
bufregistryapimodule.V1Beta1CommitServiceClientProvider
},
Expand All @@ -129,14 +129,14 @@ func getUniversalProtoCommitsForRegistryAndModuleRefs(
switch digestType {
case bufmodule.DigestTypeB4:
v1beta1ProtoResourceRefs := moduleRefsToV1Beta1ProtoResourceRefs(moduleRefs)
v1beta1ProtoCommits, err := getV1Beta1ProtoCommitsForRegistryAndResourceRefs(ctx, clientProvider, registry, v1beta1ProtoResourceRefs, digestType)
v1beta1ProtoCommits, err := getV1Beta1ProtoCommitsForRegistryAndResourceRefs(ctx, moduleClientProvider, registry, v1beta1ProtoResourceRefs, digestType)
if err != nil {
return nil, err
}
return slicesext.MapError(v1beta1ProtoCommits, newUniversalProtoCommitForV1Beta1)
case bufmodule.DigestTypeB5:
v1ProtoResourceRefs := moduleRefsToV1ProtoResourceRefs(moduleRefs)
v1ProtoCommits, err := getV1ProtoCommitsForRegistryAndResourceRefs(ctx, clientProvider, registry, v1ProtoResourceRefs)
v1ProtoCommits, err := getV1ProtoCommitsForRegistryAndResourceRefs(ctx, moduleClientProvider, registry, v1ProtoResourceRefs)
if err != nil {
return nil, err
}
Expand All @@ -148,11 +148,11 @@ func getUniversalProtoCommitsForRegistryAndModuleRefs(

func getV1ProtoCommitsForRegistryAndResourceRefs(
ctx context.Context,
clientProvider bufregistryapimodule.V1CommitServiceClientProvider,
moduleClientProvider bufregistryapimodule.V1CommitServiceClientProvider,
registry string,
v1ProtoResourceRefs []*modulev1.ResourceRef,
) ([]*modulev1.Commit, error) {
response, err := clientProvider.V1CommitServiceClient(registry).GetCommits(
response, err := moduleClientProvider.V1CommitServiceClient(registry).GetCommits(
ctx,
connect.NewRequest(
&modulev1.GetCommitsRequest{
Expand All @@ -172,7 +172,7 @@ func getV1ProtoCommitsForRegistryAndResourceRefs(

func getV1Beta1ProtoCommitsForRegistryAndResourceRefs(
ctx context.Context,
clientProvider bufregistryapimodule.V1Beta1CommitServiceClientProvider,
moduleClientProvider bufregistryapimodule.V1Beta1CommitServiceClientProvider,
registry string,
v1beta1ProtoResourceRefs []*modulev1beta1.ResourceRef,
digestType bufmodule.DigestType,
Expand All @@ -181,7 +181,7 @@ func getV1Beta1ProtoCommitsForRegistryAndResourceRefs(
if err != nil {
return nil, err
}
response, err := clientProvider.V1Beta1CommitServiceClient(registry).GetCommits(
response, err := moduleClientProvider.V1Beta1CommitServiceClient(registry).GetCommits(
ctx,
connect.NewRequest(
&modulev1beta1.GetCommitsRequest{
Expand Down

0 comments on commit 64eda56

Please sign in to comment.