Skip to content

Commit

Permalink
Small adjustment to comments
Browse files Browse the repository at this point in the history
  • Loading branch information
doriable committed Nov 7, 2024
1 parent 2ea60d0 commit e1a1c6e
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion private/bufpkg/bufmodule/bufmodulecache/base_provider.go
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,8 @@ func (p *baseProvider[K, V]) getValuesForKeys(ctx context.Context, keys []K) ([]
// We are getting the values again so that we retrieve the values from the cache directly.
// This matters for ie ModuleDatas where the storage.Bucket attached will have local paths
// instead of empty local paths if read from the cache. We documment NewModuleDataProvider
// to return a ModuleDataProvider that will always have local paths for returned storage.Buckets.
// to return a ModuleDataProvider that will always have local paths for returned storage.Buckets,
// if the cache is an on-disk cache.
var delegateNotFoundKeys []K
delegateValues, delegateNotFoundKeys, err = p.storeGetValuesForKeys(ctx, notFoundKeys)
if err != nil {
Expand Down

0 comments on commit e1a1c6e

Please sign in to comment.