Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract all bufsync.*Funcs into a bufsync.Handler #2554

Merged
merged 6 commits into from
Nov 10, 2023
Merged

Extract all bufsync.*Funcs into a bufsync.Handler #2554

merged 6 commits into from
Nov 10, 2023

Conversation

saquibmian
Copy link
Contributor

This also improves the testing to be blackbox; we invoke sync and assert on the end-state.

@saquibmian
Extract all bufsync.*Funcs into a bufsync.Handler
79ea8e9 
This also improves the testing to be blackbox; we invoke sync and assert on the end-state.
unmultimedio
unmultimedio reviewed Nov 9, 2023
View reviewed changes
Copy link
Member

@unmultimedio unmultimedio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this clean up!

private/buf/bufsync/bufsync.go Outdated Show resolved Hide resolved
private/buf/cmd/buf/command/alpha/repo/reposync/reposync.go Outdated Show resolved Hide resolved
private/buf/bufsync/bufsync_test.go Outdated Show resolved Hide resolved
private/buf/bufsync/bufsync_test.go Outdated Show resolved Hide resolved
private/buf/bufsync/commits_to_sync_test.go Outdated Show resolved Hide resolved
private/buf/bufsync/prepare_sync_test.go Outdated Show resolved Hide resolved
@saquibmian saquibmian merged commit 3b837ea into main Nov 10, 2023
@saquibmian saquibmian deleted the smian/refactor-syncer branch November 10, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unmultimedio unmultimedio unmultimedio approved these changes

@doriable doriable Awaiting requested review from doriable

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saquibmian @unmultimedio