Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add buf generate configs and update other packages to use these configs #2637

Merged
merged 76 commits into from
Dec 11, 2023
Merged

Add buf generate configs and update other packages to use these configs #2637

merged 76 commits into from
Dec 11, 2023

Conversation

oliversun9
Copy link
Contributor

@oliversun9 oliversun9 commented Dec 2, 2023 •
edited
Loading

This PR

  • Adds buf generate related configs to bufconfig
  • Update package bufgen to use these new configs
  • Update package bufimagemodify to use these new configs
    • With some small cleanups/TODOs left
    • When all else is done, this package can be moved to bufgen/internal
  • Update package buffetch to deal with input configs.
    • It is worth mentioning that a GetInputConfigForString is added. This is added to allow migrating command line inputs into buf gen v2. Migrating CLI input is important because buf gen v1 config has types, which cannot exist without an input in buf gen v2.

About 20 - 30 changed files are files deleted from bufimagemodify.

@oliversun9
init
4f01250
@oliversun9
commit
dc09dab
@oliversun9
update input config and managed config
d80be02
@oliversun9
ModuleFullNameString -> ModuleFullName
0715e66
@oliversun9
remove ImageFile interface
7b50b79
@oliversun9
move const to the top
99b3741
@oliversun9
remove type switch from plugin config
175a45a
@oliversun9
godoc
4d6b7bb
@oliversun9
Merge branch 'bufmod' into osun/bufgen-interface
9af86dd
@oliversun9
add some concrete types
48c2747
@oliversun9
rename
e73b9c7
@oliversun9
Merge branch 'osun/bufgen-interface' into osun/bufgen-move-v1
29f34a5
@oliversun9
commit
33698bd
@oliversun9
make java_package_prefix, java_package_suffix and etc. file options a…
bac4b04 
…s well; remove Prefix() and Suffix() from ManagedOverrideRule
@oliversun9
Merge branch 'osun/bufgen-interface' into osun/bufgen-move-v1
ecf6d25
@oliversun9
parse managed v1 config into the new config interface; need testing
0d80c90
@oliversun9
commit
5bea9fe
@oliversun9
type config and plugin config
1a440e0
@oliversun9
TODO
930e373
@oliversun9
rename
193f4ac
@oliversun9
plugin config tests
2bd20c2
@oliversun9
add some tests; need more for managed; need to debug the code comment…
088cd69 
…ed out in gnenerate_managed_config.go
@oliversun9
tests for managed mode config v1 -> parsed config
cd3b026
@oliversun9
add logic to bufimagemodify to support the new config; the old stuff …
5f3e185 
…are stil there; need testing
@oliversun9
added TODO
2789756
@oliversun9
rename file to a more temporary name
a3fcd61
@oliversun9
checkpoint; going to move some stuff from bufimagemodify to bufgen
15f0801
@oliversun9
make New..Override public
0e6539f
@oliversun9
commit
c7a7906
@oliversun9
Merge branch 'bufmod' into osun/bufgen-interface
aec9faa
@oliversun9 oliversun9 marked this pull request as draft December 2, 2023 06:04
@bufdev bufdev marked this pull request as ready for review December 11, 2023 17:42
@bufdev bufdev changed the title [WIP] Add buf generate configs and update other packages to use these configs Add buf generate configs and update other packages to use these configs Dec 11, 2023
@bufdev bufdev merged commit 15af023 into bufmod Dec 11, 2023
2 of 7 checks passed
@bufdev bufdev deleted the osun/bufgen-move-v1 branch December 11, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bufdev bufdev bufdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oliversun9 @bufdev