Update bufimagemodify exports #2668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes two changes that unblocks other repos that depend on
bufimagemodify:ModifyXYZtobufimagemodifyto allow modifying only some options.GetDisablesForOtherOptionsand the caller can callGetDisablesForOtherOptions(fileOpionA, fileOpionB)to modify only A and B, but this operates on the assumption that no new file options will be added to the list of file options in managed mode.ModifyPreserveExisting(this was a flag in v1, but not used by the CLI), which tells Modify[XYZ] not to modify an option if it's already set in the proto file.TODO: Testing in this package needs to be revamped, especially after these functions are added.