Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecated field to curated plugins config and upload #3421

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Conversation

mfridman
Copy link
Member

@mfridman mfridman commented Oct 25, 2024

This PR adds the ability to set the deprecated status in the buf.plugin.yaml and also in the upload RPC.

We already exposed this on the CuratedPlugin message, but we need a way to set it in the initial upload. This should help resolve issues around plugin syncs in new clusters (i.e., to correctly mark curated plugins as deprecated).

@mfridman mfridman requested a review from bufdev as a code owner October 25, 2024 17:22
@mfridman mfridman changed the title Add deprecated field to curated plugin Add deprecated field to curated plugins config and upload Oct 25, 2024
Copy link
Contributor

github-actions bot commented Oct 25, 2024

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedOct 25, 2024, 5:24 PM

@mfridman mfridman merged commit 9ec7745 into main Oct 25, 2024
11 checks passed
@mfridman mfridman deleted the mf/plugins branch October 25, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants