Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move registry commit and label commands under modules #3454

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

emcfarlane
Copy link
Contributor

This moves the buf registry commit and buf registry label commands under buf registry module as buf registry module commit and buf registry module label respectively. The commands buf registry commit and buf registry label are marked as deprecated as well as all of their subcommands.

The help-tree for buf registry module --help-tree:

module         Manage BSR modules
  commit       Manage a module's commits
    add-label  Add labels to a commit
    info       Get commit information
    list       List modules commits
    resolve    Resolve commit from a reference
  create       Create a BSR module
  delete       Delete a BSR module
  deprecate    Deprecate a BSR module
  info         Get a BSR module
  label        Manage a module's labels
    archive    Archive a module label
    info       Show label information
    list       List module labels
    unarchive  Unarchive a module label
  undeprecate  Undeprecate a BSR module
  update       Update BSR module settings

This moves the `buf registry commit` and `buf registry label` commands
under `buf registry module`. The standalone commands are marked as
deprecated and hidden.
Copy link
Contributor

github-actions bot commented Nov 7, 2024

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedNov 13, 2024, 4:57 PM

Short: `Manage Buf modules. All commands are deprecated and have moved to the "buf config", "buf dep", or "buf registry" subcommands.`,
Deprecated: `All commands are deprecated and have moved to the "buf config", "buf dep", or "buf registry" subcommands.`,
Short: `Manage Buf modules, all commands are deprecated and have moved to the "buf config", "buf dep", or "buf registry" subcommands.`,
Deprecated: `all commands are deprecated and have moved to the "buf config", "buf dep", or "buf registry" subcommands.`,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uses the lowercase to allow building the string message with ,:

$ buf mod
Command "mod" is deprecated, all commands are deprecated and have moved to the "buf config", "buf dep", or "buf registry" subcommands.
...

The short message above was altered to match althought it's never displayed as Hidden: true is set.

Copy link
Member

@doriable doriable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, and it's nice to clean-up the message casing.

@emcfarlane emcfarlane merged commit 5fda66b into main Nov 13, 2024
10 checks passed
@emcfarlane emcfarlane deleted the ed/moveRegistryModuleCmds branch November 13, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants