Set Go package option pointing to generated SDK #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… merged and then synced/pushed
jhump
commented
Jan 11, 2024
| @@ -15,7 +15,7 @@ jobs: | |||
| steps: | |||
| - uses: actions/checkout@v3 | |||
| - uses: bufbuild/buf-setup-action@v1 | |||
| - uses: bufbuild/[email protected] | |||
| # - uses: bufbuild/[email protected] | |||
There was a problem hiding this comment.
This is temporary and will be reverted after this change is merged and then sync'ed to the BSR.
bufdev
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
github.com/bufbuild/prototransformpackage uses this import path, so this seems like the canonical Go import path that should be documented in the proto itself. This is also consistent with the option inprotovalidate.We may want to update the breaking change detection logic in
bufto allow changing a Go package from empty to non-empty, because the Go plugin will not actually generate any code if it's empty. So previously (with no option), users had to provide a-Moption to the plugin in order to actually import this file and generate Go code. So setting the package now should not actually break anyone.