Skip to content

Commit

Permalink
[1.1.2] Migration from Tailwind -> UnoCSS & Bug fixes (#48)
Browse files Browse the repository at this point in the history
* 1.1.2 hopefully dont need a followup commit, if i do oof

* quick refactors

* fix date on changelog
  • Loading branch information
buffet-time authored Jun 30, 2024
1 parent 336ebd2 commit 6803d9b
Show file tree
Hide file tree
Showing 39 changed files with 1,906 additions and 1,290 deletions.
3 changes: 2 additions & 1 deletion .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@
"@vue/typescript/recommended",
"plugin:@typescript-eslint/recommended-type-checked",
"plugin:@typescript-eslint/stylistic-type-checked",
"plugin:depend/recommended"
"plugin:depend/recommended",
"@unocss"
],
"parser": "vue-eslint-parser",
"parserOptions": {
Expand Down
2 changes: 0 additions & 2 deletions .prettierrc
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
{
"plugins": ["prettier-plugin-tailwindcss"],
"tailwindConfig": "./tailwind.config.js",
"useTabs": true,
"printWidth": 80,
"singleQuote": true,
Expand Down
1 change: 0 additions & 1 deletion .vscode/extensions.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"Vue.volar",
"dbaeumer.vscode-eslint",
"esbenp.prettier-vscode",
"bradlc.vscode-tailwindcss",
"csstools.postcss",
"ban.spellright",
"YoavBls.pretty-ts-errors",
Expand Down
5 changes: 3 additions & 2 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
"[svg]": {
"editor.defaultFormatter": "jock.svg"
},
"files.associations": {
"*.css": "tailwindcss"
"[vue]": {
"editor.defaultFormatter": "esbenp.prettier-vscode"
},
"typescript.tsdk": "node_modules\\typescript\\lib",
}
18 changes: 17 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,25 @@
- Improve UX
- Shadow in chart
- Have temporary storage of removed albums from resizing to refill
- Show changelog in Site Info!
- Bug Fixes
- Album search preview being cutoff
- Fix Last.fm!!
- Add better guard rails to chart names
- Add guard rails to custom presets

## Version 1.1.2 - June 29th, 2024

- Bug Fixes
- Album search preview being cutoff
- [Firefox] - Fix inability to edit album title and name

- Performance/ Stability
- Migration from Tailwind -> UnoCSS
- This was a lot of work, slightly changes how the site looks
- includes a lot of small CSS tweaks and changes
- Notably faster CSS compared to Tailwind
- Updating all packages
- except ESLint to 9 because it's a lot of tedious work

## Version 1.1.1 - June 5th, 2024

Expand Down
2 changes: 1 addition & 1 deletion GUIDELINES.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ Heavily preferred for you to use VSCode so ESLint, Prettier, and Volar (vue 3 to

(This is also a hierarchy, prefer using no computation if possible.)

- If you don't need to compute anything use Tailwind classes.
- If you don't need to compute anything use UnoCSS classes.

- If you need to do computation ([docs here](https://vuejs.org/guide/essentials/class-and-style.html))

Expand Down
31 changes: 15 additions & 16 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "musicchartsite",
"description": "A website to create Music Charts",
"version": "1.1.1",
"version": "1.1.2",
"type": "module",
"private": "true",
"author": {
Expand All @@ -10,7 +10,7 @@
"url": "https://danielTurcich.com"
},
"engines": {
"node": ">=21.7.0",
"node": ">=22.0.0",
"pnpm": ">=9.0.0"
},
"engineStrict": true,
Expand All @@ -32,34 +32,33 @@
},
"dependencies": {
"@popperjs/core": "^2.11.8",
"@vueuse/core": "^10.10.0",
"@vueuse/core": "^10.11.0",
"dialog-polyfill": "^0.5.6",
"html2canvas": "^1.4.1",
"pako": "^2.1.0",
"vue": "^3.4.27"
"vue": "^3.4.31"
},
"devDependencies": {
"@nabla/vite-plugin-eslint": "^2.0.4",
"@types/node": "^20.14.1",
"@types/node": "^20.14.9",
"@types/pako": "^2.0.3",
"@typescript-eslint/eslint-plugin": "^7.12.0",
"@typescript-eslint/parser": "^7.12.0",
"@typescript-eslint/eslint-plugin": "^7.14.1",
"@typescript-eslint/parser": "^7.14.1",
"@unocss/eslint-config": "^0.61.0",
"@unocss/transformer-directives": "^0.61.0",
"@vitejs/plugin-vue": "^5.0.5",
"@vue/eslint-config-typescript": "^13.0.0",
"autoprefixer": "^10.4.19",
"eslint": "8.56.0",
"eslint-config-prettier": "^9.1.0",
"eslint-plugin-depend": "^0.7.0",
"eslint-plugin-depend": "^0.8.0",
"eslint-plugin-prettier": "^5.1.3",
"eslint-plugin-vue": "^9.26.0",
"husky": "^9.0.11",
"postcss": "^8.4.38",
"prettier": "^3.3.0",
"prettier-plugin-tailwindcss": "^0.6.1",
"tailwindcss": "^3.4.3",
"typescript": "^5.4.5",
"vite": "^5.2.12",
"prettier": "^3.3.2",
"typescript": "^5.5.2",
"unocss": "^0.61.0",
"vite": "^5.3.2",
"vue-eslint-parser": "^9.4.3",
"vue-tsc": "^2.0.19"
"vue-tsc": "^2.0.22"
}
}
Loading

0 comments on commit 6803d9b

Please sign in to comment.