Skip to content

Commit

Permalink
[1.2.0] Last.fm, Chart Titles, Text Shadows, and more (#50)
Browse files Browse the repository at this point in the history
* we so back

* we so back 2

* we so back 3

* we so back 4

* we so back 5
  • Loading branch information
buffet-time authored Jul 15, 2024
1 parent 8733865 commit a4c2964
Show file tree
Hide file tree
Showing 19 changed files with 855 additions and 753 deletions.
16 changes: 6 additions & 10 deletions .github/workflows/build-master.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:

steps:
# Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
- uses: actions/checkout@v3
- uses: actions/checkout@v4

# Read the pnpm version from the `.pnpmrc` file
- name: Read .pnpmrc
Expand All @@ -21,24 +21,20 @@ jobs:
path: ./.pnpmrc

- name: Cache PNPM modules
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: ~/.pnpm-store
key: ${{ runner.os }}-${{ hashFiles('**/pnpm-lock.yaml') }}
restore-keys: ${{ runner.os }}-

- uses: pnpm/action-setup@v2.2.2
- uses: pnpm/action-setup@v4
with:
version: '${{ steps.pnpm_version.outputs.content }}'

# Read node version from `.nvmrc` file
- id: nvmrc
uses: browniebroke/read-nvmrc-action@v1

- uses: actions/setup-node@v3
- uses: actions/setup-node@v4
with:
# use the output from the action
node-version: '${{ steps.nvmrc.outputs.node_version }}'
node-version-file: '.nvmrc'

- name: Install `node_modules`
run: pnpm install
Expand All @@ -50,7 +46,7 @@ jobs:
run: pnpm build

- name: Deploy
uses: JamesIves/github-pages-deploy-action@v4.3.3
uses: JamesIves/github-pages-deploy-action@v4.6.3
with:
branch: gh-pages
folder: dist
14 changes: 5 additions & 9 deletions .github/workflows/pr-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:

steps:
# Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
- uses: actions/checkout@v3
- uses: actions/checkout@v4

# Read the pnpm version from the `.pnpmrc` file
- name: Read .pnpmrc
Expand All @@ -20,24 +20,20 @@ jobs:
path: ./.pnpmrc

- name: Cache PNPM modules
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: ~/.pnpm-store
key: ${{ runner.os }}-${{ hashFiles('**/pnpm-lock.yaml') }}
restore-keys: ${{ runner.os }}-

- uses: pnpm/action-setup@v2.2.2
- uses: pnpm/action-setup@v4
with:
version: '${{ steps.pnpm_version.outputs.content }}'

# Read node version from `.nvmrc` file
- id: nvmrc
uses: browniebroke/read-nvmrc-action@v1

- uses: actions/setup-node@v3
- uses: actions/setup-node@v4
with:
# use the output from the action
node-version: '${{ steps.nvmrc.outputs.node_version }}'
node-version-file: '.nvmrc'

- name: Install `node_modules`
run: pnpm install
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
21
22
5 changes: 2 additions & 3 deletions .vscode/extensions.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,8 @@
"Vue.volar",
"dbaeumer.vscode-eslint",
"esbenp.prettier-vscode",
"csstools.postcss",
"ban.spellright",
"YoavBls.pretty-ts-errors",
"jock.svg"
"jock.svg",
"antfu.unocss"
]
}
2 changes: 0 additions & 2 deletions .vscode/spellright.dict

This file was deleted.

23 changes: 19 additions & 4 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,30 @@
## Future Version changes planned

- Features/ Enhancements
- Have a way to have the top 100 album chart titles fit to the size of the chart
- blargh this is hard
- Improve accessibility
- Improve UX
- Shadow in chart
- Have temporary storage of removed albums from resizing to refill
- Have a loading state image as images are lazy loaded
- Add more options to sorting stored charts
- And add folders

## Version 1.2.0 - July 14, 2024

- Features/ Enhancements
- The text now fits properly and on one line next to the chart no matter the size
- Removed FontSize option, as this is now algorithmically determined.
- Shadow in chart
- Removed Text Outline Option as this uses the underlying tech, but gives you more fine grain control.
- Bug Fixes
- Fix Last.fm!!
- Fixed Last.fm chart creation
- I have no idea what i was doing with the original version, that was dogshit code.
- Also cleaned up other Last.fm code.
- Fixed Show Album Titles toggle
- Fixed Save Image saving the space where Titles are, even if the titles aren't shown
- Fixed last.fm/ other album images failed to load where it shows the title in the chart overflowing if text is too large
- Performance/ Stability
- Updating all packages
- Updated GitHub CI actions

## Version 1.1.3 - July 2nd, 2024

Expand Down
27 changes: 13 additions & 14 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "musicchartsite",
"description": "A website to create Music Charts",
"version": "1.1.3",
"version": "1.2.0",
"type": "module",
"private": "true",
"author": {
Expand Down Expand Up @@ -35,36 +35,35 @@
"@vueuse/core": "^10.11.0",
"dialog-polyfill": "^0.5.6",
"html2canvas": "^1.4.1",
"marked": "^13.0.1",
"marked": "^13.0.2",
"pako": "^2.1.0",
"vue": "^3.4.31"
},
"devDependencies": {
"@eslint/eslintrc": "^3.1.0",
"@eslint/js": "^9.6.0",
"@eslint/migrate-config": "^1.1.1",
"@eslint/js": "^9.7.0",
"@nabla/vite-plugin-eslint": "^2.0.4",
"@types/node": "^20.14.9",
"@types/node": "^20.14.10",
"@types/pako": "^2.0.3",
"@typescript-eslint/eslint-plugin": "^7.15.0",
"@typescript-eslint/parser": "^7.15.0",
"@unocss/eslint-config": "^0.61.0",
"@unocss/transformer-directives": "^0.61.0",
"@typescript-eslint/eslint-plugin": "^7.16.0",
"@typescript-eslint/parser": "^7.16.0",
"@unocss/eslint-config": "^0.61.3",
"@unocss/transformer-directives": "^0.61.3",
"@vitejs/plugin-vue": "^5.0.5",
"@vue/eslint-config-typescript": "^13.0.0",
"eslint": "^9.6.0",
"eslint": "^9.7.0",
"eslint-config-prettier": "^9.1.0",
"eslint-plugin-depend": "^0.8.0",
"eslint-plugin-prettier": "^5.1.3",
"eslint-plugin-vue": "^9.27.0",
"globals": "^15.8.0",
"husky": "^9.0.11",
"prettier": "^3.3.2",
"prettier": "^3.3.3",
"rollup-plugin-swc-minify": "^1.1.1",
"typescript": "^5.5.3",
"unocss": "^0.61.0",
"vite": "^5.3.2",
"unocss": "^0.61.3",
"vite": "^5.3.3",
"vue-eslint-parser": "^9.4.3",
"vue-tsc": "^2.0.24"
"vue-tsc": "^2.0.26"
}
}
Loading

0 comments on commit a4c2964

Please sign in to comment.