-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to templates that better accomodate Pen Test report writing #521
base: master
Are you sure you want to change the base?
Conversation
Updated all first instances of SSL to read as Secure Sockets Layer (SSL)
Replaced instances of PitM with MitM to align with OWASP standard naming convention
This reverts commit 23276e0. Reverting to keep acronym as PitM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few minor corrections and then it's good to go
@@ -1,6 +1,6 @@ | |||
# Recommendation(s) | |||
|
|||
It is recommended to implement SSL certificate pinning for the application. | |||
It is recommended to implement Sockets Layer (SSL) certificate pinning for the application. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing "Secure" here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we be migrating each instance of SSL to TLS? While it's somewhat universal, SSL as a term is deprecated and has been for a long time.
|
||
## Overview of the Vulnerability | ||
|
||
Mobile security misconfigurations can occur at any level of the application stack and can involve unpatched software, unprotected files or pages, or unauthorized access to the application. SSL pinning adds an extra layer of security for an application as it forces the application to validate the server’s CA certificate against a known copy. | ||
Mobile security misconfigurations can occur at any level of the application stack and can involve unpatched software, unprotected files or pages, or unauthorized access to the application. Sockets Layer (SSL) pinning adds an extra layer of security for an application as it forces the application to validate the server’s CA certificate against a known copy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing "Secure" before "Sockets Layer (SSL)"
@@ -1,6 +1,6 @@ | |||
# Recommendation(s) | |||
|
|||
It is recommended to securely implement SSL certificate pinning for the application. | |||
It is recommended to securely implement Sockets Layer (SSL) certificate pinning for the application. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing "Secure" before "Sockets Layer (SSL)"
|
||
## Overview of the Vulnerability | ||
|
||
Mobile security misconfigurations can occur at any level of the application stack and can involve unpatched software, unprotected files or pages, or unauthorized access to the application. SSL pinning adds an extra layer of security for an application as it forces the application to validate the server’s CA certificate against a known copy. | ||
Mobile security misconfigurations can occur at any level of the application stack and can involve unpatched software, unprotected files or pages, or unauthorized access to the application. Sockets Layer (SSL) pinning adds an extra layer of security for an application as it forces the application to validate the server’s CA certificate against a known copy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing "Secure" before "Sockets Layer (SSL)"
denial of service
, with,Denial of Service
.*Replaced all instance of
Navigate to {{url}}
, with,Navigate to the following URL: {{url}}