Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to templates that better accomodate Pen Test report writing #521

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

RRudder
Copy link
Contributor

@RRudder RRudder commented Nov 24, 2023

  • Replaced all instance of denial of service, with, Denial of Service.
    *Replaced all instance of Navigate to {{url}}, with, Navigate to the following URL: {{url}}
  • Updated all first instances of SSL to read as Secure Sockets Layer (SSL)

@RRudder RRudder changed the title denial of service to Denial of Service Changes to templates that better accomodate Pen Test report writing Nov 24, 2023
Updated all first instances of SSL to read as Secure Sockets Layer (SSL)
Replaced instances of PitM with MitM to align with OWASP standard naming convention
This reverts commit 23276e0.

Reverting to keep acronym as PitM.
@RRudder RRudder marked this pull request as draft December 12, 2023 04:56
@RRudder RRudder marked this pull request as ready for review December 12, 2023 05:23
Copy link

@norsec0de norsec0de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor corrections and then it's good to go

@@ -1,6 +1,6 @@
# Recommendation(s)

It is recommended to implement SSL certificate pinning for the application.
It is recommended to implement Sockets Layer (SSL) certificate pinning for the application.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing "Secure" here

Copy link
Contributor

@vortexau vortexau May 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be migrating each instance of SSL to TLS? While it's somewhat universal, SSL as a term is deprecated and has been for a long time.


## Overview of the Vulnerability

Mobile security misconfigurations can occur at any level of the application stack and can involve unpatched software, unprotected files or pages, or unauthorized access to the application. SSL pinning adds an extra layer of security for an application as it forces the application to validate the server’s CA certificate against a known copy.
Mobile security misconfigurations can occur at any level of the application stack and can involve unpatched software, unprotected files or pages, or unauthorized access to the application. Sockets Layer (SSL) pinning adds an extra layer of security for an application as it forces the application to validate the server’s CA certificate against a known copy.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing "Secure" before "Sockets Layer (SSL)"

@@ -1,6 +1,6 @@
# Recommendation(s)

It is recommended to securely implement SSL certificate pinning for the application.
It is recommended to securely implement Sockets Layer (SSL) certificate pinning for the application.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing "Secure" before "Sockets Layer (SSL)"


## Overview of the Vulnerability

Mobile security misconfigurations can occur at any level of the application stack and can involve unpatched software, unprotected files or pages, or unauthorized access to the application. SSL pinning adds an extra layer of security for an application as it forces the application to validate the server’s CA certificate against a known copy.
Mobile security misconfigurations can occur at any level of the application stack and can involve unpatched software, unprotected files or pages, or unauthorized access to the application. Sockets Layer (SSL) pinning adds an extra layer of security for an application as it forces the application to validate the server’s CA certificate against a known copy.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing "Secure" before "Sockets Layer (SSL)"

@RRudder RRudder marked this pull request as draft September 26, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants