-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tts hide toolbar #328
base: master
Are you sure you want to change the base?
tts hide toolbar #328
Conversation
@teleshoes, go back to conversations with good ideas )) |
haha, i guess it was my idea, though you fixed it by having it toggle instead of dedicated toolbar button to hide. |
I mean any other good ideas, not this case. |
yea, i PR'd just this one simple idea, for least-change to most directly resolve issue #320, with a minimum of things anyone could reasonably object to. edit: in case i misunderstood you yet again...i will happily continue posting any ideas where you and others can find them :D |
@teleshoes , as for me it would be suitable on my discussion board: |
c5093d8
to
50850bf
Compare
50850bf
to
3c3e7f1
Compare
3c3e7f1
to
44d0ef9
Compare
when clicking outside of the TTS toolbar, show/hide the TTS toolbar, instead of stopping TTS.
this fixes issue #320
many thanks to @plotn for the idea and implementation outline!
p.s.: the majority of this PR is whitespace/indentation. skip the first commit to see just the actual changes