SMTP module: Fix response code and Cyrillic character handling issues #277
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two issues were identified with the SMTP server:
When terminating the DATA command with the end-of-data marker (a single period), the server incorrectly sent two "250" response codes in sequence, causing errors with some clients during concurrent email sending. [SMTP] Two response codes returned for end of data command #274
When sending emails with Cyrillic content, especially with larger volumes of text, clients would receive an error:
Expected response code "354" but got code "250"
. This was due to improper handling of multi-byte characters and SMTP state management.Changes Made
1. In
Service.php
:2. In
Message.php
:Testing