Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update expo-cli #131

Open
wants to merge 3 commits into
base: v48/next
Choose a base branch
from
Open

Conversation

KBirzins
Copy link

Goal

By default when creating a new Expo project with the typescript template, the entry point file is App.tsx not App.ts, so the script to import and start Bugsnag fails. This update checks also for the App.tsx file and inserts if found.

Design

Reused existing approach, only extended it

Changeset

Extended existing functionality in insert.js, adding extra check for App.tsx file.

Testing

Added tests for App.tsx extension.

Add App.tsx to possible files to check
Add tests for App.tsx
@matthewjhowells
Copy link

Hi @KBirzins, Thanks for raising this. We'll look to get this merged in due course.

@matthewjhowells matthewjhowells added bug Confirmed bug backlog We hope to fix this feature/bug in the future labels May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog We hope to fix this feature/bug in the future bug Confirmed bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants