Support Expo SDK 50 #161
Merged
Support Expo SDK 50 #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gingerbenw
reviewed
Feb 7, 2024
| @@ -117,7 +117,7 @@ Scenario: Network breadcrumbs are captured by default | |||
| And the exception "message" equals "defaultNetworkBreadcrumbsBehaviour" | |||
| And the event has a "request" breadcrumb named "XMLHttpRequest succeeded" | |||
| And the event "breadcrumbs.1.metaData.status" equals 200 | |||
| And the event "breadcrumbs.1.metaData.request" equals "GET http://postman-echo.com/get" | |||
| And the event "breadcrumbs.1.metaData.request" equals "GET https://postman-echo.com/get" | |||
packages/expo/test/index.test.js
Outdated
| /** | ||
| * @jest-environment jsdom | ||
| */ | ||
|
|
There was a problem hiding this comment.
is this the right environment for expo?
There was a problem hiding this comment.
no it's not! The issue was the network breadcrumbs plugin, I've updated the test to mock that out instead
yousif-bugsnag
force-pushed
the
PLAT-11488/support-v50
branch
from
c18358b to
e618c25
Compare
yousif-bugsnag
force-pushed
the
PLAT-11488/support-v50
branch
from
e618c25 to
a7995ab
Compare
gingerbenw
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Adds support for Expo SDK 50
Changeset
jest-expopreset for unit tests.Testing
Relied on CI and unit tests