fix(electron): handle error events on the response stream during deli…

…very
bugsnag · Oct 13, 2023 · 4114261 · 4114261
1 parent 775699d
commit 4114261
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,8 @@
 
 - (electron) Fix startup crash when using Electron v26+ on Linux [#2022](https://github.com/bugsnag/bugsnag-js/pull/2022)
 
+- (electron) Fix unhandled response errors from Electron net [#2025](https://github.com/bugsnag/bugsnag-js/pull/2025)
+
 ## 7.22.0 (2023-09-13)
 
 ### Changes

diff --git a/packages/delivery-electron/delivery.js b/packages/delivery-electron/delivery.js
@@ -13,6 +13,14 @@ const delivery = (client, filestore, net, app) => {
 
     const req = net.request(opts, response => {
       req.removeListener('error', errorHandler)
+
+      // in some cases (e.g. proxy authentication errors) Electron net
+      // will emit an error event on the response stream
+      response.on('error', (err) => {
+        err.isRetryable = isRetryable(response.statusCode)
+        cb(err)
+      })
+
       if (isOk(response)) {
         cb(null)
       } else {