Skip to content

Commit

Permalink
ci(react-native): run react navigation scenarios as part of main test…
Browse files Browse the repository at this point in the history
… run
  • Loading branch information
yousif-bugsnag committed Sep 18, 2024
1 parent 6cbe7c9 commit f422314
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 8 deletions.
2 changes: 0 additions & 2 deletions .buildkite/basic/react-native-android-pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ steps:
manual:
permit_on_passed: true
env:
SKIP_NAVIGATION_SCENARIOS: "true"
RN_VERSION: "{{matrix}}"
RCT_NEW_ARCH_ENABLED: "0"
concurrency: 25
Expand Down Expand Up @@ -111,7 +110,6 @@ steps:
manual:
permit_on_passed: true
env:
SKIP_NAVIGATION_SCENARIOS: "true"
RCT_NEW_ARCH_ENABLED: "1"
RN_VERSION: "{{matrix}}"
concurrency: 25
Expand Down
2 changes: 0 additions & 2 deletions .buildkite/basic/react-native-ios-pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ steps:
manual:
permit_on_passed: true
env:
SKIP_NAVIGATION_SCENARIOS: "true"
RN_VERSION: "{{matrix}}"
RCT_NEW_ARCH_ENABLED: "0"
concurrency: 25
Expand Down Expand Up @@ -110,7 +109,6 @@ steps:
- --aws-public-ip
env:
RCT_NEW_ARCH_ENABLED: "1"
SKIP_NAVIGATION_SCENARIOS: "true"
RN_VERSION: "{{matrix}}"
retry:
manual:
Expand Down
4 changes: 1 addition & 3 deletions scripts/generate-react-native-fixture.js
Original file line number Diff line number Diff line change
Expand Up @@ -114,9 +114,7 @@ if (process.env.BUILD_IOS === 'true' || process.env.BUILD_IOS === '1') {
}

function installFixtureDependencies() {
if (!process.env.RCT_NEW_ARCH_ENABLED) {
DEPENDENCIES.push(...REACT_NAVIGATION_DEPENDENCIES)
}
DEPENDENCIES.push(...REACT_NAVIGATION_DEPENDENCIES)

const fixtureDependencyArgs = DEPENDENCIES.join(' ')

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { getCurrentCommand } from './CommandRunner'
import { NativeInterface } from './native'
import Bugsnag from '@bugsnag/react-native'

async function runScenario (scenarioName, apiKey, notifyEndpoint, sessionEndpoint, scenarioData) {
async function runScenario (scenarioName, apiKey, notifyEndpoint, sessionEndpoint, scenarioData, setScenario) {
console.error(`[Bugsnag ScenarioLauncher] running scenario: ${scenarioName}`)

const nativeConfig = {
Expand Down

0 comments on commit f422314

Please sign in to comment.