-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PLAT-9555] Update release script #1939
Conversation
bin/release.sh
Outdated
git push origin $TAG | ||
|
||
# publish | ||
npx lerna publish from-package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we want from-git
instead of from-package
?
bump from-git
… This will identify packages tagged by lerna version and publish them to npm. This is useful in CI scenarios where you wish to manually increment versions, but have the package contents themselves consistently published by an automated process.
from-package
still sounds best for RETRY_PUBLISH
though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's what I initially thought - but I saw in a recent nx walkthrough of lerna they used it this way... let's stick with the documentation though
bin/release.sh
Outdated
WORKER_PACKAGE_CHANGED=$(npx lerna changed --parseable | grep -c packages/web-worker$ || test $? = 1;) | ||
# push latest git tag | ||
TAG=$(git describe --tags --abbrev=0) | ||
git push origin $TAG |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
git push origin $TAG | |
git push origin "$TAG" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to push 1 tag specifically, or would git push --tags
be OK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think push --tags would be okay actually, as it's from a fresh docker container
7ef707d
to
7352876
Compare
7352876
to
492261a
Compare
492261a
to
31276d4
Compare
6dec777
to
b2a8715
Compare
Co-authored-by: Joe Haines <[email protected]>
b2a8715
to
715c2fb
Compare
Goal
Previously, the release script would increment version numbers of changed packages after building, meaning that production bundles including the package version would be one version out of date on every release, skewing the internal metrics for version usage.