Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAT-9555] Update release script #1939

Merged
merged 8 commits into from
Jan 11, 2024
Merged

Conversation

gingerbenw
Copy link
Member

Goal

Previously, the release script would increment version numbers of changed packages after building, meaning that production bundles including the package version would be one version out of date on every release, skewing the internal metrics for version usage.

@github-actions
Copy link

github-actions bot commented Mar 14, 2023

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 43.67 kB 13.40 kB
After 43.67 kB 13.40 kB
± No change No change

code coverage diff

<temporarily disabled>

Generated by 🚫 dangerJS against 715c2fb

@gingerbenw gingerbenw marked this pull request as ready for review March 14, 2023 17:06
@gingerbenw gingerbenw requested a review from imjoehaines March 14, 2023 17:06
bin/release.sh Outdated Show resolved Hide resolved
bin/release.sh Outdated
git push origin $TAG

# publish
npx lerna publish from-package
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want from-git instead of from-package?

bump from-git

… This will identify packages tagged by lerna version and publish them to npm. This is useful in CI scenarios where you wish to manually increment versions, but have the package contents themselves consistently published by an automated process.

from-package still sounds best for RETRY_PUBLISH though

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's what I initially thought - but I saw in a recent nx walkthrough of lerna they used it this way... let's stick with the documentation though

@gingerbenw gingerbenw requested a review from imjoehaines March 15, 2023 11:15
bin/release.sh Outdated Show resolved Hide resolved
bin/release.sh Outdated
WORKER_PACKAGE_CHANGED=$(npx lerna changed --parseable | grep -c packages/web-worker$ || test $? = 1;)
# push latest git tag
TAG=$(git describe --tags --abbrev=0)
git push origin $TAG
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
git push origin $TAG
git push origin "$TAG"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to push 1 tag specifically, or would git push --tags be OK?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think push --tags would be okay actually, as it's from a fresh docker container

bin/release.sh Outdated Show resolved Hide resolved
@gingerbenw gingerbenw requested a review from imjoehaines March 15, 2023 16:43
@gingerbenw gingerbenw force-pushed the PLAT-9555/fix-release-script branch from 7ef707d to 7352876 Compare June 28, 2023 17:29
@yousif-bugsnag yousif-bugsnag force-pushed the PLAT-9555/fix-release-script branch from 7352876 to 492261a Compare September 15, 2023 12:58
@gingerbenw gingerbenw force-pushed the PLAT-9555/fix-release-script branch from 492261a to 31276d4 Compare October 31, 2023 13:35
@gingerbenw gingerbenw changed the base branch from next to master October 31, 2023 13:35
@gingerbenw gingerbenw force-pushed the PLAT-9555/fix-release-script branch from 6dec777 to b2a8715 Compare October 31, 2023 13:47
@yousif-bugsnag yousif-bugsnag force-pushed the PLAT-9555/fix-release-script branch from b2a8715 to 715c2fb Compare January 11, 2024 11:26
@yousif-bugsnag yousif-bugsnag changed the base branch from master to next January 11, 2024 11:27
@yousif-bugsnag yousif-bugsnag merged commit 3225cf6 into next Jan 11, 2024
155 checks passed
@yousif-bugsnag yousif-bugsnag deleted the PLAT-9555/fix-release-script branch January 11, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants