Move react-native-navigation tests to dynamic fixture setup #2202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yousif-bugsnag
force-pushed
the
PLAT-12066/wix-rn-navigation-dynamic-fixture
branch
3 times, most recently
from
a43168b to
ee80c8e
Compare
Base automatically changed from
PLAT-12066/rn-navigation-dynamic-fixture
to
next
September 23, 2024 12:32
An error occurred while trying to automatically change base from
PLAT-12066/rn-navigation-dynamic-fixture
to
next
September 23, 2024 12:32
…fixture dynamically
yousif-bugsnag
force-pushed
the
PLAT-12066/wix-rn-navigation-dynamic-fixture
branch
from
ee80c8e to
11aa3df
Compare
yousif-bugsnag
force-pushed
the
PLAT-12066/wix-rn-navigation-dynamic-fixture
branch
from
11aa3df to
38fbff2
Compare
gingerbenw
approved these changes
Sep 24, 2024
Comment on lines
+392
to
+393
| # Skipped due to build failures with react-native-navigation when new arch is enabled | ||
| # TODO: Investigate and try to re-enable when we add tests for more recent React Native versions |
There was a problem hiding this comment.
prefer raising a ticket and adding skip: "See PLAT-1234" than commenting out
There was a problem hiding this comment.
Discussed this with @tomlongridge and we decided not to raise a ticket for this because it's not something we can fix on our side - instead we'll re-assess when we come to add the next RN version to the test matrix.
yousif-bugsnag
deleted the
PLAT-12066/wix-rn-navigation-dynamic-fixture
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Converts the e2e tests for
@bugsnag/plugin-react-native-navigationto the dynamic fixture setup and adds e2e tests for React Native 0.71 and 0.72.Design
This requires a separate test fixture, which is generated dynamically if the
REACT_NATIVE_NAVIGATIONenvironment variable is set.The scenarios and feature files have also been separated as previously these used the same naming as the react-navigation scenarios.
Due to some issues in react-native-navigation itself, these tests are currently skipped for:
rnn-link)The legacy static e2e tests for react-navigation and react-native-navigation have been removed.
Testing
Covered by a full CI run