Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🚀 update release script after lerna version change #2235

Merged
merged 4 commits into from
Oct 23, 2024
Merged

fix: 🚀 update release script after lerna version change #2235

merged 4 commits into from
Oct 23, 2024

Conversation

gingerbenw
Copy link
Member

@gingerbenw gingerbenw commented Oct 23, 2024 •
edited
Loading

Goal

Ensure release script runs correctly

@github-actions GitHub Actions
Copy link

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 45.89 kB 13.78 kB
After 45.89 kB 13.78 kB
± No change No change

code coverage diff

<temporarily disabled>

Generated by 🚫 dangerJS against bac2e08

gingerbenw
gingerbenw commented Oct 23, 2024
View reviewed changes
.github/workflows/pr-diff.yml
@@ -22,7 +22,6 @@ jobs:
run: |
mkdir .diff
npm ci
npx lerna bootstrap
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added in release branch as main still required the bootstrap command - but doesn't any more

@gingerbenw gingerbenw marked this pull request as ready for review October 23, 2024 16:01
@gingerbenw gingerbenw merged commit 365d63c into next Oct 23, 2024
59 checks passed
@gingerbenw gingerbenw deleted the hotfix/release-script branch October 23, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomlongridge tomlongridge tomlongridge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gingerbenw @tomlongridge