Refactor @bugsnag/plugin-client-ip #2260
Merged
+71
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnastasiiaSvietlova
changed the base branch from
next
to
integration/typescript
gingerbenw
reviewed
Nov 25, 2024
| */ | ||
| const plugin: Plugin = { | ||
| load: client => { | ||
| // @ts-expect-error _config is private API |
There was a problem hiding this comment.
could we extend the Plugin interface here to get rid of these instances of ts-expect-error?
gingerbenw
force-pushed
the
PLAT-13090-plugin-client-ip
branch
from
c391bf4 to
0059f4f
Compare
gingerbenw
reviewed
Nov 26, 2024
| /* | ||
| * Prevent collection of user IPs | ||
| */ | ||
| const plugin: Plugin = { |
There was a problem hiding this comment.
you can also change this to
interface ExtendedPlugin extends Plugin {
configSchema: Record<string, ValidationOption>
}
interface ValidationOption {
validate: (value: unknown) => boolean
defaultValue: () => unknown
message: string
}
to remove the need for the second @ts-expect-error
gingerbenw
approved these changes
Nov 26, 2024
gingerbenw
pushed a commit
that referenced
this pull request
Dec 5, 2024
* refactor @bugsnag/plugin-client-ip * fix rollup config * update with internal client * update extended plugin interface * fix value type to unknown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Convert source code to TypeScript and export both es modules and common js modules
Testing
Covered by existing test suite