Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix angular build issue #2271

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Fix angular build issue #2271

merged 1 commit into from
Dec 5, 2024

Conversation

gingerbenw
Copy link
Member

@gingerbenw gingerbenw commented Dec 5, 2024 •
edited
Loading

Goal

Workaround ES2015 differential bundle issue by targeting ES5.

Testing

Existing CI Tests

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 45.89 kB 13.78 kB
After 45.89 kB 13.78 kB
± No change No change

code coverage diff

<temporarily disabled>

Generated by 🚫 dangerJS against af5c69e

@gingerbenw gingerbenw changed the title test: ✅ change target to ES5 to prevent differential… Fix angular build issue Dec 5, 2024
@gingerbenw gingerbenw marked this pull request as ready for review December 5, 2024 12:30
@gingerbenw
Copy link
Member Author

Merging with failing test resolved in #2269

@gingerbenw gingerbenw merged commit 1b8eba7 into next Dec 5, 2024
57 of 59 checks passed
@gingerbenw gingerbenw deleted the gingerbenw/fix-angular-tests branch December 5, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twometresteve twometresteve twometresteve approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gingerbenw @twometresteve