Generate type definition using Angular 17 #2275
Open
+16,998
−19,333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gingerbenw
force-pushed
the
PLAT-13302/angular-type-definition
branch
2 times, most recently
from
11f76f4 to
a039da2
Compare
gingerbenw
force-pushed
the
PLAT-13302/angular-type-definition
branch
from
a039da2 to
d7bd486
Compare
gingerbenw
commented
Dec 12, 2024
| @@ -57,7 +57,7 @@ import 'core-js/es7/reflect'; | |||
| /*************************************************************************************************** | |||
| * Zone JS is required by default for Angular itself. | |||
| */ | |||
| import 'zone.js/dist/zone'; // Included with Angular CLI. | |||
| import 'zone.js'; // Included with Angular CLI. | |||
gingerbenw
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Ensure
@bugsnag/plugin-angularworks with recent versions of angularDesign
Update dev dependency to v17 to ensure that generated types are compatible with Angular 17 (earliest supported version according to the angular documentation)
Changeset
Update dependencies to v17
Testing
Update test fixture to v17 and test against full ci build