Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ruby 3.3 to CI #808

Merged
merged 5 commits into from
Jan 8, 2024
Merged

Add Ruby 3.3 to CI #808

merged 5 commits into from
Jan 8, 2024

Conversation

imjoehaines
Copy link
Contributor

Goal

Add Ruby 3.3 to CI

Changeset

  • assert against in-project frames in the plain ruby unhandled error tests — Ruby 3.3 adds additional frames to the top of these stacktraces
  • update "undefined local variable" message assertions:
    • Ruby <3.3:

      undefined local variable or method `generate_unhandled_error' for #<BeforeNotifyController>

    • Ruby 3.3:

      undefined local variable or method `generate_unhandled_error' for an instance of BeforeNotifyController

  • add Ruby 3.3 to matrices
  • fix dependency issue in the Rails 7 fixture when running with Ruby 2.7

@imjoehaines
Fix dependency issue on Ruby 2.7 in rails7 fixture
5a6fd85
@imjoehaines
Assert against in-project frames only
c032d00 
Ruby 3.3 adds additional frames to the top of the stacktrace so frame 0
is no longer the frame we want to assert against
@imjoehaines
Update 'undefined local variable' error message
37d60e5 
Ruby 3.3 changes the format slightly

Ruby <3.3:
> undefined local variable or method `generate_unhandled_error' for #<BeforeNotifyController

Ruby 3.3:
> undefined local variable or method `generate_unhandled_error' for an instance of BeforeNotifyController
@imjoehaines
Bump Ruby 3.2 -> 3.3 in Maze Runner tests
7ec41a7
@imjoehaines
Add Ruby 3.3 to test matrix
e79a9ee
@imjoehaines imjoehaines merged commit 5240a4f into next Jan 8, 2024
137 checks passed
@imjoehaines imjoehaines deleted the ruby-3.3-ci branch January 8, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomlongridge tomlongridge tomlongridge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imjoehaines @tomlongridge