Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cleaner#clean_url with mailto links #813

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Fix Cleaner#clean_url with mailto links #813

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86808df
Handle mailto links in Cleaner#clean_url
imjoehaines Jan 23, 2024
8660ddd
Rescue unexpected errors
imjoehaines Jan 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions lib/bugsnag/cleaner.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,16 +30,18 @@ def clean_url(url)

begin
uri = URI(url)

if uri.is_a?(URI::MailTo)
clean_mailto_url(url, uri)
else
clean_generic_url(url, uri)
end
rescue URI::InvalidURIError
pre_query_string, _query_string = url.split('?', 2)

return "#{pre_query_string}?#{FILTERED}"
end

if uri.is_a?(URI::MailTo)
clean_mailto_url(url, uri)
else
clean_generic_url(url, uri)
"#{pre_query_string}?#{FILTERED}"
rescue StandardError
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! Thanks for this.

FILTERED
end
end

Expand Down
Loading