Merge pull request #5 from bugsnag/win7-hostname-fallback

Fall back to using environment variables when os.hostname fails
bugsnag · Nov 25, 2022 · 526a418 · 526a418
2 parents 4af4f8c + affecd8
commit 526a418
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/lib/fingerprint.js b/lib/fingerprint.js
@@ -5,7 +5,16 @@ function getHostname () {
   try {
       return os.hostname();
   } catch (e) {
-      return '';
+    /**
+     * This is most likely Windows 7 which is known to cause os.hostname() to break
+     * @see https://github.com/nodejs/node/issues/41297
+     * @see https://github.com/libuv/libuv/issues/3260
+     *
+     * Fallback to take hostname from environment variables
+     * @see https://docs.microsoft.com/en-us/windows-server/administration/windows-commands/hostname#notes
+     */
+    // eslint-disable-next-line no-underscore-dangle
+    return process.env._CLUSTER_NETWORK_NAME_ || process.env.COMPUTERNAME || 'hostname';
     }
 }