Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor binary release workflow #7167

Merged
merged 6 commits into from
Dec 18, 2023
Merged

refactor binary release workflow #7167

merged 6 commits into from
Dec 18, 2023

Conversation

metaclips
Copy link
Member

@metaclips metaclips commented Dec 18, 2023 •
edited
Loading

  • Ensure that we can release without needing a -ff merge to retain git commit SHA
  • We can now release crates even where there are no changes to the ockam, ockam_command, and ockam_app_lib crate
  • We now use same version of ockam, ockam_app_lib and ockam_command

How release workflow runs

  • Create a PR that bumps the version of our crates, after PR is created, script waits for PR to be merged
  • PR merged and script automatically detects and start release from the develop branch

@metaclips metaclips force-pushed the metaclips/refactor_binary_release_workflow branch 7 times, most recently from fe95b45 to 532af1e Compare December 18, 2023 16:31
@metaclips metaclips force-pushed the metaclips/refactor_binary_release_workflow branch from 532af1e to 5927db0 Compare December 18, 2023 16:56
@metaclips metaclips marked this pull request as ready for review December 18, 2023 16:56
@metaclips metaclips requested a review from a team as a code owner December 18, 2023 16:56
@metaclips metaclips enabled auto-merge December 18, 2023 17:03
@davide-baldo
Copy link
Member

@metaclips
Why do we need to bump one of those three crates in order to release?

@metaclips metaclips added this pull request to the merge queue Dec 18, 2023
@mrinalwadhwa mrinalwadhwa removed this pull request from the merge queue due to a manual request Dec 18, 2023
@metaclips metaclips added this pull request to the merge queue Dec 18, 2023
@metaclips
Copy link
Member Author

@metaclips Why do we need to bump one of those three crates in order to release?
We need the version desktop app and CLI to be same

Merged via the queue into develop with commit 89663f7 Dec 18, 2023
41 checks passed
@metaclips metaclips deleted the metaclips/refactor_binary_release_workflow branch December 18, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrinalwadhwa mrinalwadhwa mrinalwadhwa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@metaclips @davide-baldo @mrinalwadhwa