Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App - handling email validation as en enrollment state #7190

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

davide-baldo
Copy link
Member

@davide-baldo davide-baldo commented Dec 19, 2023

Added WaitForEmailValidation as an enrollment phase, with its relative view during enrollment.
Removed email validation notification.

Waiting for 10 seconds instead of 5 to keep the API rate low enough to avoid failure, this is valid for both command and portals.

@davide-baldo davide-baldo requested a review from a team as a code owner December 19, 2023 18:40
@davide-baldo davide-baldo marked this pull request as draft December 19, 2023 18:40
@mrinalwadhwa mrinalwadhwa force-pushed the davide-baldo/app-wait-for-email-validation branch from 92688bd to 34e6400 Compare December 19, 2023 21:12
@mrinalwadhwa mrinalwadhwa marked this pull request as ready for review December 19, 2023 21:12
@mrinalwadhwa
Copy link
Member

@davide-baldo that worked great. I changed some text and added the start enrollment again button.

@davide-baldo davide-baldo added this pull request to the merge queue Dec 19, 2023
Merged via the queue into develop with commit 107ae29 Dec 19, 2023
39 checks passed
@davide-baldo davide-baldo deleted the davide-baldo/app-wait-for-email-validation branch December 19, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants