feat(rust): add a command to migrate a postgres database #8756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etorreborre
force-pushed
the
etorreborre/feat/migration-executable
branch
2 times, most recently
from
c339ccc to
71e6622
Compare
etorreborre
force-pushed
the
etorreborre/feat/migration-executable
branch
2 times, most recently
from
f4659bb to
41e06ce
Compare
implementations/rust/ockam/ockam_command/src/migrate_database/mod.rs
Outdated
Show resolved
Hide resolved
.../rust/ockam/ockam_node/src/storage/database/migrations/migration_support/migration_result.rs
Outdated
Show resolved
Hide resolved
.../rust/ockam/ockam_node/src/storage/database/migrations/migration_support/migration_status.rs
Outdated
Show resolved
Hide resolved
| Conflicts: | implementations/rust/ockam/ockam_command/src/lib.rs | implementations/rust/ockam/ockam_command/src/subcommand.rs | Conflicts: | implementations/rust/ockam/ockam_command/src/lib.rs | implementations/rust/ockam/ockam_command/src/subcommand.rs
etorreborre
force-pushed
the
etorreborre/feat/migration-executable
branch
from
6e491da to
8523dd6
Compare
adrianbenavides
approved these changes
Jan 21, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
migrate-postgrescommand which can be used to check the migration status of a shared Postgres database and to migrate the current schema/data.Implementation notes
host_journeytableI added the
host_journeytable to still be able to collect traces when there are command errors, even in contexts where a project does not exists.This allows to not change the existing code too much for the
migrate-postgrescommand. Indeed that command might fail if theOCKAM_DATABASE_CONNECTION_URLenvironment variable is not defined and in that case we create a command error user event.MigrationStatus
Most of the change consist in reporting richer data about the status of migrations, instead of simple booleans and errors.
Note that a failed migration is reported with an
Ok(status)and RustErrors are left for infrastructure errors (broken connection for example).Version
I introduced a wrapper type,
Version, aroundi64for versions, to give that value its own meaning and make sure we don't make undue conversions.