Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rust): custom branding config allows you to specify which commands are included #8769

Merged
merged 4 commits into from
Jan 24, 2025

Conversation

adrianbenavides
Copy link
Member

@adrianbenavides adrianbenavides commented Jan 22, 2025

In the configuration passed to the brand binary, we can now pass the commands we want to include and optionally set a custom name. If none are passed, all the commands are available:

bin_name:
  commands:
    - node: "host" # 'node' top-level command will be renamed to 'host'
    - node_list
    - node_create: "init" # 'node create' -> 'host init'

So far I’ve added the ability to add/rename top-level commands only (e.g. node, project, space, ...) but not subcommands.

@adrianbenavides adrianbenavides force-pushed the adrian/custom-branding-continued_2 branch 2 times, most recently from a125ce0 to dd6c692 Compare January 22, 2025 15:52
@adrianbenavides adrianbenavides marked this pull request as ready for review January 22, 2025 16:16
@adrianbenavides adrianbenavides requested a review from a team as a code owner January 22, 2025 16:16
@adrianbenavides adrianbenavides force-pushed the adrian/custom-branding-continued_2 branch from dd6c692 to 3c3d3fa Compare January 23, 2025 13:48
@adrianbenavides adrianbenavides force-pushed the adrian/custom-branding-continued_2 branch from 3c3d3fa to 6fe8973 Compare January 23, 2025 13:49
@adrianbenavides adrianbenavides force-pushed the adrian/custom-branding-continued_2 branch from 6fe8973 to 888cba0 Compare January 23, 2025 13:49
Copy link
Member

@etorreborre etorreborre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐰

@adrianbenavides adrianbenavides added this pull request to the merge queue Jan 24, 2025
Merged via the queue into develop with commit 8143e50 Jan 24, 2025
44 checks passed
@adrianbenavides adrianbenavides deleted the adrian/custom-branding-continued_2 branch January 24, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants