feat(rust): make portal handshake optional #8777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SanjoDeundiak
force-pushed
the
sanjo/portal_handshake
branch
6 times, most recently
from
585ac2c to
2346830
Compare
SanjoDeundiak
force-pushed
the
sanjo/portal_handshake
branch
from
2346830 to
102fe51
Compare
davide-baldo
reviewed
Feb 5, 2025
davide-baldo
reviewed
Feb 5, 2025
davide-baldo
previously approved these changes
Feb 5, 2025
implementations/rust/ockam/ockam_transport_tcp/src/portal/outlet_listener.rs
Outdated
Show resolved
Hide resolved
SanjoDeundiak
force-pushed
the
sanjo/portal_handshake
branch
from
102fe51 to
f051d92
Compare
SanjoDeundiak
force-pushed
the
sanjo/portal_handshake
branch
from
f051d92 to
f9f12e6
Compare
davide-baldo
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--skip-handshakeflag to tcp inlets&outlets, that makes handshake non-blocking to optimize latency (but possibly sacrificing throughput)--enable-nagleflag to tcp inlets&outlets. By default we set nodelay flag on TCP streams, but that may sometimes be unwanted (for high throughput use cases)