convert build views to a more tabular layout for improved performance and UX #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also touched a few files typescript files w/a formatter. I'd love to add typescript formatting to CI at some point |
mortenmj
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as mentioned in issue #65 the build view is super slow in environments where there are a lot of invocations per build event. Even 2 dozen will slow things down substantially and cause views to break.
This PR converts the build view to something more tabular and honestly more consumable. The old UI was legacy code while there were some parts that were nice and it worked well for smaller builds, in a production environment it created problems and was confusing.
Additional trying to consume all those invocations on 1 page was a bit overwhelming and not particularly useful, and it grows more confusing w/the more invocations you add to a build, so the new plan is to just give them a list with a few key elements that you can sort by and then provide a link if you need to drill down into the invocation itself.
The new UI will contain a fair amount of data and if we find something is missing we can always add it.